1. Forum
  2. DOVE-Net
  3. Synchronet Programming

  • src/sbbs3/services.cpp

    From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Fri Dec 12 23:42:12 2025
    https://gitlab.synchro.net/main/sbbs/-/commit/23e465ca78e0348003d6cc70
    Modified Files:
    src/sbbs3/services.cpp
    Log Message:
    Hack around the protected_uint32_t allocation issue

    macOS builds failling with link errors:

    Undefined symbols for architecture arm64:
    "operator new(unsigned long)", referenced from:
    _services_thread in services.o
    ld: symbol(s) not found for architecture arm64

    and

    Undefined symbols for architecture x86_64:
    "operator new(unsigned long)", referenced from:
    _services_thread in services.o
    ld: symbol(s) not found for architecture x86_64

    We need to use new for when the std Atomic class is used however, since we
    need (?) to invoke the constructor.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Sat Dec 13 00:10:42 2025
    https://gitlab.synchro.net/main/sbbs/-/commit/9a41a0d4fb4a61dfa78ea8d4
    Modified Files:
    src/sbbs3/services.cpp
    Log Message:
    Revert "Hack around the protected_uint32_t allocation issue"

    This reverts commit 23e465ca78e0348003d6cc7023213519421bf25d.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Sat Dec 13 15:23:19 2025
    https://gitlab.synchro.net/main/sbbs/-/commit/af34887eb934266787192c8e
    Modified Files:
    src/sbbs3/services.cpp
    Log Message:
    Fix the (newly introduced, small) service[].clients memory leak

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Sat Jan 17 14:10:39 2026
    https://gitlab.synchro.net/main/sbbs/-/commit/0d6074e0dbc8566359e90f8d
    Modified Files:
    src/sbbs3/services.cpp
    Log Message:
    Missed a spot where logoutuserdat was called without checking LoginInfoSave ARS

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Debian Linux)@VERT to Git commit to main/sbbs/master on Wed May 6 19:41:53 2026
    https://gitlab.synchro.net/main/sbbs/-/commit/306c753155781bdb5147f988
    Modified Files:
    src/sbbs3/services.cpp
    Log Message:
    services: suppress login_attempt_list lock false-positives (CIDs 631138, 631139, 639948, 643135)

    loginAttempts() and loginBanned() each call listLock+listUnlock
    internally on the link_list, leaving the mutex unlocked across the
    return. Coverity's inter-procedural lock tracking misses the matching
    unlock and reports:
    - LOCK: native_service_thread returning without unlocking
    - SLEEP: mswait while holding the lock (after loginAttempts)
    - LOCK: loginBanned re-locks while supposedly already locked

    None of these are real Ä the call sites never hold the mutex. Annotate
    the call sites with a SUPPRESS pointing at the invariant.

    CID 643138 (Y2K38_SAFETY for time32_t cast in connect-rate report) is deliberate Ä timestr() is a time32_t API by design Ä and is left for
    the project-wide Y2K38 architectural decision.

    Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net